Move Phpseclib adapter into its own namespace #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flug
approved these changes
Feb 10, 2017
PedroTroller
requested changes
Mar 2, 2017
| use Gaufrette\Adapter; | ||
| use phpseclib\Net\SFTP as SecLibSFTP; | ||
| use Gaufrette\Filesystem; | ||
| use Gaufrette\File; | ||
|
|
||
| /** | ||
| * @deprecated 0.4 This adapter is deprecated since version 0.4. Use Gaufrette\Adapters\Phpseclib\Sftp instead. | ||
| */ | ||
| class PhpseclibSftp implements Adapter, |
There was a problem hiding this comment.
I think the old classe should extends from the new one to not duplicates the code.
stof
reviewed
Mar 2, 2017
| }, | ||
| "require-dev": { | ||
| "phpspec/phpspec": "^3.1", | ||
| "phpunit/phpunit": "3.7.*" |
There was a problem hiding this comment.
3.7 ? Seriously ? This is unmaintained since 5 years at least.
Use ^4.8.35 || ^5.7 instead (and then work on switching to the namespaced test case and add || ^6 in the condition)
| processIsolation="false" | ||
| stopOnFailure="false" | ||
| syntaxCheck="false" | ||
| bootstrap="tests/bootstrap.php.dist" |
| $baseDir = dirname(__DIR__); | ||
|
|
||
| $loader = require __DIR__.'/../vendor/autoload.php'; | ||
| $loader->add('Gaufrette', array($baseDir.'/vendor/knplabs/gaufrette/tests/')); |
There was a problem hiding this comment.
use autoload-dev instead of altering the configuration of the generated loader. this will make this whole file useless
|
|
||
| $loader = require __DIR__.'/../vendor/autoload.php'; | ||
| $loader->add('Gaufrette', array($baseDir.'/vendor/knplabs/gaufrette/tests/')); | ||
| $loader->register(); |
There was a problem hiding this comment.
useless as it is already registered in autoload.php
| @@ -2,11 +2,16 @@ | |||
|
|
|||
| namespace Gaufrette\Adapter; | |||
|
|
|||
| @trigger_error('The '.__NAMESPACE__.'\PhpseclibSftp is deprecated since version 0.4. Use Gaufrette\Adapters\Phpseclib\Sftp instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
wrong namespace. Adapter is not a plural
akerouanton
force-pushed
the
split/phpseclib-adapter
branch
from
dc1ba4d to
753c1a5
Compare
akerouanton
force-pushed
the
split-adapters
branch
from
7c789a9 to
4c00d7f
Compare
akerouanton
force-pushed
the
split/phpseclib-adapter
branch
4 times, most recently
from
e6d8a48 to
382ebc7
Compare
akerouanton
force-pushed
the
split/phpseclib-adapter
branch
from
382ebc7 to
3eda698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #440