remove deprecated spaceless

[tacman]

better performance, etc.

twigphp/Twig#4236

[tacman]

well, so much for a simple remove -- all the tests needs to change. So this becomes a bigger issue, one of using the whitespace control, rather than spaceless.

[ro0NL]

i guess it's real simple to override the template in userland, but not sure if this library is longlived still.

[tacman]

but not sure if this library is longlived still.

I quite like this library, all of my projects depend on it. I guess I should make a PR for the tests then, yes?

[ro0NL]

#399 -.-

[curry684]

but not sure if this library is longlived still

We're using it in a lot of projects, and I don't really see anything 'bad'. Why would it be abandoned?

[garak]

but not sure if this library is longlived still

We're using it in a lot of projects, and I don't really see anything 'bad'. Why would it be abandoned?

The reasons are explained in the link provided in the first comment

[curry684]

The reasons are explained in the link provided in the first comment

That's all about the spaceless filter in Twig, @ro0NL said "this library" in an issue about the KnpMenu library. @tacman and I interpret that as him expressing doubts about the future of the KnpMenu library.

[garak]

#399 was just merged, do you think this PR could still stand? Maybe to solve the problem in a better way?

[curry684]

This PR is not a basis for the fundamental fix, which should rely on whitespace control through tags instead, and will by definition be a breaking change.