Skip to content

Commit

Permalink
Merge pull request #48 from kukulili-labs/master
Browse files Browse the repository at this point in the history 
Add symfony 2.3 support
  • Loading branch information
@pilot
pilot committed Nov 15, 2013
2 parents 1e827fd + d2b0f7f commit 0d5a317
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

"require": {
"php": ">=5.3.3",
"symfony/framework-bundle": "~2.0"
"symfony/framework-bundle": ">=2.0,<2.4-dev"
},

"suggest": {
Expand Down

2 comments on commit 0d5a317

@nurikabe
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought ~2.0 meant >=2.0,<3.0? In other words, any version from 2.0 and above (including 2.3), but not a major bump to 3.x. Maybe I'm misreading the composer docs.

At any rate, this change means I can't use the bundle in 2.4.

@sstok
Copy link
Contributor

@sstok sstok commented on 0d5a317 Nov 17, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, ~2.0 is better.
~2.0 means >=2.0,<3.0, but ~2.0.1 means >=2.0.1,<2.1 so I guess this is were the confusion happens.

This change should be reverted.

Please sign in to comment.