Skip to content

Commit

Permalink
Add index on succeeded tasks (#164)
Browse files Browse the repository at this point in the history
* Add index on task table

* also add models file

* add make commands and limit index

* format
  • Loading branch information
GDay authored Sep 8, 2024
1 parent 2191897 commit 69e794f
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 0 deletions.
9 changes: 9 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ dev:
test:
docker-compose -f test-services-docker-compose.yaml run --rm django-q2 poetry run pytest

shell:
docker-compose -f test-services-docker-compose.yaml run --rm django-q2 poetry run python manage.py shell

makemigrations:
docker-compose -f test-services-docker-compose.yaml run --rm django-q2 poetry run python manage.py makemigrations

migrate:
docker-compose -f test-services-docker-compose.yaml run --rm django-q2 poetry run python manage.py migrate

createsuperuser:
docker compose -f web-docker-compose.yaml run --rm web python manage.py createsuperuser

Expand Down
20 changes: 20 additions & 0 deletions django_q/migrations/0018_task_success_index.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Generated by Django 4.2.7 on 2024-03-05 17:03

from django.db import migrations, models


class Migration(migrations.Migration):
dependencies = [
("django_q", "0017_task_cluster_alter"),
]

operations = [
migrations.AddIndex(
model_name="task",
index=models.Index(
condition=models.Q(("success", True)),
fields=["group", "name", "func"],
name="success_index",
),
),
]
8 changes: 8 additions & 0 deletions django_q/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from django import get_version
from django.core.exceptions import ValidationError
from django.db import models
from django.db.models import Q
from django.template.defaultfilters import truncatechars
from django.urls import reverse
from django.utils import timezone
Expand Down Expand Up @@ -111,6 +112,13 @@ def __str__(self):
class Meta:
app_label = "django_q"
ordering = ["-stopped"]
indexes = [
models.Index(
name="success_index",
fields=["group", "name", "func"],
condition=Q(success=True),
),
]


class SuccessManager(models.Manager):
Expand Down

0 comments on commit 69e794f

Please sign in to comment.