fix(auth_service): legacy wallet bip39 validation #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only rethrow validation exceptions for HD wallets
CharlVS
requested changes
Dec 20, 2024
naezith
approved these changes
Dec 20, 2024
Co-authored-by: Charl (Nitride) <[email protected]>
There were no changes besides the suggested change (format & fix on save to the rescue) |
CharlVS
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the login issue reported by @naezith
Steps to reproduce:
On
dev, logging into an Iguana wallet in HD mode fails with a BIP39 validation error. This is because BIP39 validation was only performed for HD wallet registrations.Changes:
AuthExceptionif the current mode is HD.