-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix desktop and android builds #19
Open
takenagain
wants to merge
19
commits into
dev
Choose a base branch
from
build/fix-desktop-builds
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takenagain
force-pushed
the
build/fix-desktop-builds
branch
from
December 23, 2024 05:21
1e6dfa6
to
c5e19dc
Compare
takenagain
force-pushed
the
build/fix-desktop-builds
branch
2 times, most recently
from
January 3, 2025 07:00
16cf0fb
to
393b078
Compare
takenagain
force-pushed
the
build/fix-desktop-builds
branch
from
January 13, 2025 08:43
638f0ba
to
df02a43
Compare
long file paths are required on windows to build flutter_secure_storage
emulates the post build script on macos that copies the binary/lib to the application support directory
fixes permission issues on macos, ubuntu, and likely most linux distributions
iteratively look for the root .dart_tools folder containing package_config.json
workspace defaults dependency resolution to hosted (pub.dev), but none of the packages are published yet
step was initially translated over from macos podfile spec, but cmake does not directly manage packaging as-is, so KDF should be copied to the build directory of the package using komodo_defi_framework plugin
also remove dependency override, as v2.0.0 of flutter_secure_storage_web was released last week
jvm v21 (lts), gradle v8.12, build tools v8.8.0 KDF android libraries require features from API 28 and later, so minimum API level had to be increased
KDF was not linked statically or bundled with the `komodo_defi_framework` package
takenagain
force-pushed
the
build/fix-desktop-builds
branch
from
January 21, 2025 09:12
51c1256
to
cc2167d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes builds and platform specific linking errors for Windows, Linux, and Android. iOS linking is a WIP that is expected to be resolved by the update of
libp2p
in KDF.Changes
chmod
on macos - kdf binary is not in the expected path, and step does not appear to be necessarypackages/komodo_defi_framework/src/komodo_defi_framework.c
to fix CMake builds (Windows & Linux)build_config.json
$HOME/.local
for local development