Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix desktop and android builds #19

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from

Conversation

takenagain
Copy link
Collaborator

@takenagain takenagain commented Dec 20, 2024

Fixes builds and platform specific linking errors for Windows, Linux, and Android. iOS linking is a WIP that is expected to be resolved by the update of libp2p in KDF.

Changes

  • remove chmod on macos - kdf binary is not in the expected path, and step does not appear to be necessary
  • add empty file packages/komodo_defi_framework/src/komodo_defi_framework.c to fix CMake builds (Windows & Linux)
  • add missing libraries and binaries in build_config.json
  • add binary/executable copy steps for Windows and Linux
  • change default install prefix to $HOME/.local for local development

@takenagain takenagain self-assigned this Dec 20, 2024
@takenagain takenagain marked this pull request as draft December 20, 2024 14:31
@takenagain takenagain force-pushed the build/fix-desktop-builds branch from 1e6dfa6 to c5e19dc Compare December 23, 2024 05:21
@takenagain takenagain force-pushed the build/fix-desktop-builds branch 2 times, most recently from 16cf0fb to 393b078 Compare January 3, 2025 07:00
@takenagain takenagain force-pushed the build/fix-desktop-builds branch from 638f0ba to df02a43 Compare January 13, 2025 08:43
takenagain and others added 17 commits January 21, 2025 11:09
long file paths are required on windows to build flutter_secure_storage
emulates the post build script on macos that copies the binary/lib to the application support directory
fixes permission issues on macos, ubuntu, and likely most linux distributions
iteratively look for the root .dart_tools folder containing package_config.json
workspace defaults dependency resolution to hosted (pub.dev), but none of the packages are published yet
step was initially translated over from macos podfile spec, but cmake does not directly manage packaging as-is, so KDF should be copied to the build directory of the package using komodo_defi_framework plugin
also remove dependency override, as v2.0.0 of flutter_secure_storage_web was released last week
jvm v21 (lts), gradle v8.12, build tools v8.8.0

KDF android libraries require features from API 28 and later, so minimum API level had to be increased
KDF was not linked statically or bundled with the `komodo_defi_framework` package
@takenagain takenagain force-pushed the build/fix-desktop-builds branch from 51c1256 to cc2167d Compare January 21, 2025 09:12
@takenagain takenagain requested a review from CharlVS January 21, 2025 16:40
@takenagain takenagain marked this pull request as ready for review January 21, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant