Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync firodex #107

Merged
merged 9 commits into from
Feb 10, 2024
Merged

Sync firodex #107

merged 9 commits into from
Feb 10, 2024

Conversation

takenagain
Copy link
Collaborator

@takenagain takenagain commented Jan 30, 2024

@takenagain takenagain requested review from smk762 and CharlVS January 30, 2024 09:13
* Migrate BestOrders to mmrpc 2.0

Leaving the BestOrder and BestOrders attributes unchanged to minimise the impact

* Fix empty best orders list

ARRR has no `address_data` as it is a `Shielded` address, so we cannot use address to filter ARRR top orders.
@takenagain takenagain requested a review from kivqa February 2, 2024 08:45
* Update coins config files and bundled hash

* Add missing coin icons

* Update `coins_config` and bundled hash

* Update `coins_config` and bundled coin hash to `9ab1200`

* Update `space.png`
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
FIRO logo, references, default coins are correct.

FIRO, BCH coins work as expected.
ARRR best orders on Simple view work as expected.

Copy link
Contributor

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected coins present with correct logos and functional. Confirmed zhtlc coins visible in dex simple view, and trades performed between bch/firo/kmd/pirate completed without issue.

@CharlVS CharlVS merged commit 3feac23 into firodex Feb 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants