-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync firodex #107
Sync firodex #107
Conversation
* Migrate BestOrders to mmrpc 2.0 Leaving the BestOrder and BestOrders attributes unchanged to minimise the impact * Fix empty best orders list ARRR has no `address_data` as it is a `Shielded` address, so we cannot use address to filter ARRR top orders.
* Update coins config files and bundled hash * Add missing coin icons * Update `coins_config` and bundled hash * Update `coins_config` and bundled coin hash to `9ab1200` * Update `space.png`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
FIRO logo, references, default coins are correct.
FIRO, BCH coins work as expected.
ARRR best orders on Simple view work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected coins present with correct logos and functional. Confirmed zhtlc coins visible in dex simple view, and trades performed between bch/firo/kmd/pirate completed without issue.
Sync changes from
dev
: