[RC] 0.9.1: Chart & Order Book Fixes + Sync assets
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delist THC and update coins hash
* Migrate BestOrders to mmrpc 2.0 Leaving the BestOrder and BestOrders attributes unchanged to minimise the impact * Fix empty best orders list ARRR has no `address_data` as it is a `Shielded` address, so we cannot use address to filter ARRR top orders.
Includes - simple unit tests, and - repository functions that will plug into the legacy charts provider, `cex_provider.dart`
* Update coins config files and bundled hash * Add missing coin icons * Update `coins_config` and bundled hash * Update `coins_config` and bundled coin hash to `9ab1200` * Update `space.png`
Allow for scrolling over a larger time range than the currently visible candles, up to a maximum of the number of data points retrieved from the Binance API.
With the assistance of GitHub Copilot
- Add conditions to `shouldRepaint` override to reduce the number of repaint calls - Optimise min and max price calculations to reduce loop iterations. - Use regex for string matching to improve performance, compared to multiple `replaceAll` calls - Reset timeAxisScale and zoom on duration change - Limit the maximum number of visible candles to 100
When zooming in, the time axis jumped far to the left instead. It will now stick to the right time axis
- Remove touch count listener on `CoinsPriceList` widget - Change state variables to local variables in the `build` function - Refactor `CandleChart` to make CPU Flame Chart clearer and code more readable
Improve scroll and zoom responsiveness
Fixes BNB-USDC graph bug using older data
Migrate candlestick charting to Binance
…lues Fix advanced swap order book showing incorrect values
* Remove prefix from QR code scans * Remove query parameters from address and parse amount Did not modify PaymentUriInfo to avoid issues with segwit variants
* Sync coins config files from coins repo * Sync icons from coins repo * Update bundled commit hash * Update wallet only coins in `app_config.json` * Sync coin icons from coins repo 9be500c8bf665861a07002ea67de234a290c7748 * Bump version to 0.9.1 * Add vote 2024 icon * Add dpc icon
|
It all looks good, except for a couple of screens which I end up with an endless spinner.
Simple dex orderbook is fine, so it doesnt seem to be a connectivity issue. Logs only have one error including the string "orderbook" - By disabling any coins with a legacy/segwit variant (or only having one of the variants active), these pages load ok. |
* Add `orderbook_ticker` to Coin model and remove segwit pair Remove * Add segwit pair check before fetching orderbook
|
@smk762 I've merged the fix for the bug you mentioned. I would appreciate it if you or one of your team members could still create an issue with steps/conditions to reproduce the long loading times you reported. |
smk762
approved these changes
Apr 30, 2024
CharlVS
added a commit
that referenced
this pull request
Dec 19, 2024
commit 69d98b2 Author: Kadan Stadelmann <[email protected]> Date: Mon May 13 12:25:31 2024 +0200 SSL migration (#143) * Update coins to SSL config * Rename references to SSL coin config * Prefer SSL, but fall back to TCP if not available. `coins_config_ssl` delists coins without SSL support whereas `coins_config_tcp` favours SSL but falls back to TCP if not available. * Sync latest TCP file from coins repo * bump target SDK https://developer.android.com/google/play/requirements/target-sdk Signed-off-by: Kadan Stadelmann <[email protected]> * Bump app build Signed-off-by: Charl (Nitride) <[email protected]> --------- Signed-off-by: Kadan Stadelmann <[email protected]> Signed-off-by: Charl (Nitride) <[email protected]> Co-authored-by: CharlVS <[email protected]> commit 6df3044 Merge: b853544 66471b9 Author: Kadan Stadelmann <[email protected]> Date: Sat May 4 22:03:41 2024 +0200 Merge pull request #123 from KomodoPlatform/dev [RC] `0.9.1`: Chart & Order Book Fixes + Sync assets commit b853544 Merge: 68138a3 06947f9 Author: Kadan Stadelmann <[email protected]> Date: Wed Jan 24 09:34:50 2024 +0100 Merge pull request #100 from KomodoPlatform/dev sync master commit 68138a3 Merge: b0eb54a 36c6afd Author: Kadan Stadelmann <[email protected]> Date: Tue Jan 16 12:59:34 2024 +0100 Merge pull request #93 from KomodoPlatform/dev sync master commit b0eb54a Merge: 8281a1a b4d69d1 Author: Kadan Stadelmann <[email protected]> Date: Wed Dec 20 00:53:07 2023 +0100 Merge pull request #91 from KomodoPlatform/dev `0.9.0` RC - Net ID migration and file sharing fixes commit 8281a1a Author: smk762 <[email protected]> Date: Mon Oct 30 16:42:47 2023 +0800 update rates url commit 40b1eb2 Merge: 0f30d51 e32aff7 Author: Charl <[email protected]> Date: Fri Oct 20 18:38:35 2023 +0200 0.8.0 Release: Merge pull request #78 from KomodoPlatform/dev 0.8.0 Release (stable): UI revamp, bug fixes and coins update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.9.1Release Candidate PRVarious bug fixes and minor improvements relating to advanced view order book and candlestick chart.
Outstanding TODO:
Maintainer pre-review of changed dependencies(N/A)Security team review of changed dependencies(N/A)Project changelog:
VOTE2024release by adding icon asset. Coin will be pushed to app at runtime when coins repo is updated.v2endpoint.Dependency changelog & review:
Not applicable (no changes)