Fix file sharing export & log refactoring #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the coin updater more robust to exceptions thrown during updating/loading coins config data and improve logging for the loading process. The aim of this is to possibly solve the reported issues of the production app crashing (for a minority of users) when MM2 is launched.
Refactor `share` to `share_plus` and add home page log export by tapping app logo 7 times.
Sync the iOS counterparts of the changed Dart dependencies.
Throw an exception in the logs layer if there are no exported log files to share. Catch the error and show a snackbar.
GZip is the final compression algorithm used, so the file extension should be `.gz`.
|
Logs export for android 14 works as expected on real device Pixel 5 from Home screen and from Settings screen |
CharlVS
added
the
0.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change file export package used for, among other things, log exporting. The latest Android version (Android 14) has breaking changes for the package we were using that was discontinued 2 years ago. The new package is an old version of the package (
share_plus)used onkomodo-wallet. We can't re-use the reviewed version because this (old) version is the newest version compatible with our older Dart/Flutter version.Add log exporting from home page in case the user cannot access the settings page because the app crashes during wallet login. (Tap home screen logo 7 times)
Coin config updater refactoring. Background:
Make the coin updater more robust to exceptions thrown during updating/loading coins config data and improve logging for the loading process. The aim of this is to possibly solve the reported issues of the production app crashing (for a minority of users) when MM2 is launched. At the very least, this will help us get more info to diagnose the issue.
To test: