Optimise coins asset files

.github/workflows/build.yml

@@ -48,6 +48,10 @@ jobs:
         run: |
           cp android/app/src/main/cpp/libs/armeabi-v7a/libmm2.a build/api-binaries/libmm2-armeabi-v7a.a
           cp android/app/src/main/cpp/libs/arm64-v8a/libmm2.a build/api-binaries/libmm2-arm64-v8a.a
+      # Download coins assets
+      - name: Download coins assets
+        shell: bash
+        run: ${GITHUB_WORKSPACE}/fetch_coin_assets.py
       # Upload API binaries
       - name: Upload API binaries
         uses: actions/upload-artifact@v3

.github/workflows/validate_coins.yml

@@ -31,9 +31,17 @@ jobs:
       - name: Get coins repo commit
         id: coins
         run: |
-          echo "hash=$(jq -r .coins_repo_commit coins_ci.json)" >> $GITHUB_ENV
+          export commit_hash="$(jq -r .bundled_coins_repo_commit assets/coins_ci.json)"
+          if [ -z "${commit_hash}" ]; then
+            echo "No coins repo commit found in coins_ci.json"
+            exit 1
+          fi
+          echo "hash=${commit_hash}" >> $GITHUB_ENV
         shell: bash
 
+      - name: Get coins asset files 
+        run: python3 fetch_coin_assets.py
+
       - name: Get coins.json and coins_config.json from KomodoPlatform/coins repo
         run: |
           curl -O https://raw.githubusercontent.com/KomodoPlatform/coins/${hash}/coins

.gitignore

@@ -19,7 +19,9 @@
 .svn/
 
 # coins file extras
-# /assets/coins.json
+/assets/coins.json
+/assets/coins_config.json
+/assets/coin-icons
 /app_assets
 /coins_assets
 

README.md

@@ -1,4 +1,5 @@
 # Komodo Wallet - Open Source GitHub Repository 🚀
+
 ![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/komodoplatform/atomicdex-mobile/build.yml)
 ![GitHub release (latest SemVer)](https://img.shields.io/github/v/release/komodoplatform/atomicdex-mobile)
 ![GitHub contributors](https://img.shields.io/github/contributors-anon/komodoplatform/atomicdex-mobile)
@@ -13,17 +14,19 @@ Welcome to the Komodo Wallet open-source repository! This cutting-edge project i
 
 <p float="center">
   <img src="https://user-images.githubusercontent.com/77973576/229565868-b121e9b6-2d2b-4390-a81f-a7878d0bfea8.png" width="33%" />
-  <img src="https://user-images.githubusercontent.com/77973576/229565938-81a51d44-5a73-4acd-8885-454e6fa6443d.png" width="33%" /> 
+  <img src="https://user-images.githubusercontent.com/77973576/229565938-81a51d44-5a73-4acd-8885-454e6fa6443d.png" width="33%" />
   <img src="https://user-images.githubusercontent.com/77973576/229565995-252df819-1ea9-4cc8-a9bc-4ab3e1c80caf.png" width="33%" />
   <img src="https://user-images.githubusercontent.com/77973576/229566018-285b6b6d-677e-464e-aafb-e55fecb2df82.png" width="33%" />
   <img src="https://user-images.githubusercontent.com/77973576/229566049-2f25b16b-da76-4295-b4e6-ba567ac582f7.png" width="33%" />
   <img src="https://user-images.githubusercontent.com/77973576/229566075-aa00a5a9-55ae-4acd-ad7b-d67ed3a65db6.png" width="33%" />
 </p>
 
 ## Unleashing the Power of Komodo DeFi Framework 💡
+
 We've made this repository public to showcase the incredible potential of the Komodo DeFi Framework and to spark interest among companies looking to integrate this game-changing technology into their own applications. Our goal is to drive innovation and expand the reach of decentralised exchange technology worldwide.
 
 ## Exciting Features 🌟
+
 - **Non-custodial wallet:** You're in control - only you can access your private keys.
 - **Decentralized exchange:** Trade cryptocurrencies effortlessly across blockchain networks with atomic swap technology, bypassing the need for a middleman.
 - **500+ Listed Cryptocurrencies:** A vast and ever-growing list of supported cryptocurrencies.
@@ -34,58 +37,54 @@ We've made this repository public to showcase the incredible potential of the Ko
 - **Frequent updates:** Our dedicated developers are constantly working to enhance the app's user experience, security, and feature set.
 
 ## Download Komodo Wallet 📲
+
 Embrace financial freedom at your fingertips by downloading the Komodo Wallet:
 
 - [iOS](https://testflight.apple.com/join/c2mOLEoC)
 - [Android](https://play.google.com/store/apps/details?id=com.komodoplatform.atomicdex)
 
 ## Get Involved 🤝
+
 We welcome developers, designers, and testers' contributions to our open-source project. If you'd like to contribute, please review the [contribution guidelines](CONTRIBUTING.md) and [code of conduct](CODE_OF_CONDUCT.md).
 
 For any questions about the Komodo Wallet or the exchange, join our lively [Discord Support channel](https://komodoplatform.com/discord). Official team members are identifiable by the "Komodo Team" role.
 
-# NB (Forkers/contributors):
+# NB (Forkers/contributors)
 
 This repository is currently in the process of undergoing safety and Flutter version upgrades. Expect major merge conflicts in the near future for any files updated from this repository. Please note that this software is under active development and provided "as is" without warranties or guarantees. Use at your own risk, as the authors and maintainers shall not be held liable for any issues, damages, or losses resulting from its use.
 
 ## Getting Started
 
-Build requires up-to-date version of coins file from https://github.com/KomodoPlatform/coins
+Build requires up-to-date version of coins file from <https://github.com/KomodoPlatform/coins>
 
 Commit hash and sha256sum of coins file is specified in `coins_ci.json`.
-You may download one manually or use `fetch_coins.sh` script on Linux and macOS or `fetch_coins.ps1` PowerShell script on Windows.
-
-The `fetch_coins` script depends on sha256sum and jq utils:
+You may download one manually, use the `fetch_coin_assets.py` python script.
 
-Ubuntu: `sudo apt-get update && sudo apt-get install -y coreutils jq`
-
-MacOS: `brew install coreutils jq`, [Brew software](https://brew.sh/)
-
-Windows: `choco install jq`, [Choco software](https://chocolatey.org/)
+The `fetch_coin_assets.py` script requires python 3.8 or later. MacOS users might need to run the [following post-install commands](https://stackoverflow.com/a/42334357/5019115) for SSL certificate verification to work with their version of python:
 
+```bash
+pip install certifi
+/Applications/Python\ 3.12/Install\ Certificates.command
+```
 
 ## Build and run
 
-https://github.com/KomodoPlatform/AtomicDEX-mobile/wiki/Project-Setup#build-and-run
-
+<https://github.com/KomodoPlatform/AtomicDEX-mobile/wiki/Project-Setup#build-and-run>
 
 ## Run/Build with screenshot and video recording ON
 
 ```
 flutter run --dart-define=screenshot=true
 ```
 
-
-## Komodo DeFi Framework Library Setup:
+## Komodo DeFi Framework Library Setup
 
 Komodo Wallet runs the Komodo DeFi Framework locally on the user's device. The API binary is platform-specific and must be manually set up by the developer instead of a typical Flutter dependency.
 
 Ensure you run the most recent Komodo DeFi Framework [stable release](https://github.com/KomodoPlatform/atomicDEX-API/releases). Download the API binary for each platform and extract its `libmm2.a` file into the applicable platform's API folder.
 
-
-
 ### [Stable API releases](https://github.com/KomodoPlatform/atomicDEX-API/releases)
- 
+
 | API Build | API Path* |
 |--|--|
 | android-aarch64 | `android/app/src/main/cpp/libs/arm64-v8a/libmm2.a` |
@@ -104,21 +103,27 @@ See [our wiki](https://github.com/KomodoPlatform/atomicdex-mobile/wiki/Project-S
 ## Localization
 
 1. Extract messages to the .arb file:
+
 ```bash
 flutter pub run intl_generator:extract_to_arb --output-dir=lib/l10n lib/localizations.dart
 ```
+
 2. Sync generated `intl_messages.arb` with existing locale `intl_*.arb` files:
+
 ```bash
 dart run sync_arb_files.dart
 ```
+
 3. ARB files can be used for input to translation tools like [Arbify](https://github.com/Arbify/Arbify), [Localizely](https://localizely.com/) etc.
 4. The resulting translations can be used to generate a set of libraries:
+
 ```bash
 flutter pub run intl_generator:generate_from_arb --output-dir=lib/l10n  lib/localizations.dart lib/l10n/intl_*.arb
 ```
+
 5. Manual editing of generated `messages_*.dart` files might be needed to delete nullable syntax (`?` symbol), since the app doesn't support it yet.
 
-## Generate latest coin config:
+## Generate latest coin config
 
 Clone the latest version of [coins](https://github.com/KomodoPlatform/coins)
 
@@ -134,20 +139,23 @@ Copy the generated `coins_config.json` file from the Utils folder and paste it i
 
 ## Audio samples sources
 
- - [ticking sound](https://freesound.org/people/FoolBoyMedia/sounds/264498/)
- - [silence](https://freesound.org/people/Mullabfuhr/sounds/540483/)
- - [start (iOS)](https://freesound.org/people/pizzaiolo/sounds/320664/)
+- [ticking sound](https://freesound.org/people/FoolBoyMedia/sounds/264498/)
+- [silence](https://freesound.org/people/Mullabfuhr/sounds/540483/)
+- [start (iOS)](https://freesound.org/people/pizzaiolo/sounds/320664/)
 
- ## Testing
+## Testing
+
+### 1. Manual testing
 
- ### 1. Manual testing
  Manual testing plan:
 [https://docs.google.com/spreadsheets/d/1jeIkGe2CmJ7YmuoVi6Rlc9KRr3wiBPf44Qy0Nd8qtOY/edit?usp=sharing](https://docs.google.com/spreadsheets/d/1jeIkGe2CmJ7YmuoVi6Rlc9KRr3wiBPf44Qy0Nd8qtOY/edit?usp=sharing)
 
- ### 2. Integration testing
+### 2. Integration testing
+
  [Guide and coverage](integration_test/README.md)
 
- ### 3. Unit/Widget testing
+### 3. Unit/Widget testing
+
  Not supported
 
 ## License 📄