Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.0 RC - Net ID migration and file sharing fixes #91

Merged
merged 22 commits into from
Dec 19, 2023
Merged

0.9.0 RC - Net ID migration and file sharing fixes #91

merged 22 commits into from
Dec 19, 2023

Conversation

CharlVS
Copy link
Member

@CharlVS CharlVS commented Dec 19, 2023

QA Test notes:

naezith and others added 21 commits October 5, 2023 16:54
Make the coin updater more robust to exceptions thrown during updating/loading coins config data and improve logging for the loading process. The aim of this is to possibly solve the reported issues of the production app crashing (for a minority of users) when MM2 is launched.
Refactor `share` to `share_plus` and add home page log export by tapping app logo 7 times.
Sync the iOS counterparts of the changed Dart dependencies.
Throw an exception in the logs layer if there are no exported log files to share.
Catch the error and show a snackbar.
GZip is the final compression algorithm used,
so the file extension should be `.gz`.
Even though coin config files are updated at runtime, it’s a good idea to keep the bundled version up to date since it’s used on the first launch and is used as a fallback if update fails.

NB: In the near future, these files will be dropped from the repo and instead rather fetched at CI build time in PR #87 (#87).
Major release version because net ID update is a breaking change since users on old net ID cannot see order book of new net ID users. This is part of a p2p network stack upgrade for Komodo DeFi framework which opens up future possibilities for more efficient streaming-based event features.
The new Komodo DeFi Framework p2p layer changes require Android NDK >=23.
Fix file sharing export & log refactoring
Update netid, coins and bump app version
Fix - Order book showing incorrect values
@CharlVS CharlVS added the 0.9.0 v0.9.0 release: Net ID migration and order book + file export bug fixes. label Dec 19, 2023
@CharlVS CharlVS self-assigned this Dec 19, 2023
Update coin config for critical coins config update.

Update coins config and icon files to commit 26641cc1fef362063aa4e394dba8b82e7ebaf2cf of `KomodoPlatform/coins`.

NB: In the near future, the coin icon and config files will be removed from the repo and fetched and build time locally and in CI deployment using a Python script.
@CharlVS CharlVS marked this pull request as ready for review December 19, 2023 14:49
Copy link
Contributor

@ca333 ca333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps sec code reviewed

@DeckerSU plz run independent/additional review

@ca333 ca333 merged commit b0eb54a into master Dec 19, 2023
0 of 2 checks passed
CharlVS added a commit that referenced this pull request Dec 19, 2024
commit 69d98b2
Author: Kadan Stadelmann <[email protected]>
Date:   Mon May 13 12:25:31 2024 +0200

    SSL migration (#143)

    * Update coins to SSL config

    * Rename references to SSL coin config

    * Prefer SSL, but fall back to TCP if not available.

    `coins_config_ssl` delists coins without SSL support whereas `coins_config_tcp` favours SSL but falls back to TCP if not available.

    * Sync latest TCP file from coins repo

    * bump target SDK

    https://developer.android.com/google/play/requirements/target-sdk

    Signed-off-by: Kadan Stadelmann <[email protected]>

    * Bump app build

    Signed-off-by: Charl (Nitride) <[email protected]>

    ---------

    Signed-off-by: Kadan Stadelmann <[email protected]>
    Signed-off-by: Charl (Nitride) <[email protected]>
    Co-authored-by: CharlVS <[email protected]>

commit 6df3044
Merge: b853544 66471b9
Author: Kadan Stadelmann <[email protected]>
Date:   Sat May 4 22:03:41 2024 +0200

    Merge pull request #123 from KomodoPlatform/dev

    [RC] `0.9.1`: Chart & Order Book Fixes + Sync assets

commit b853544
Merge: 68138a3 06947f9
Author: Kadan Stadelmann <[email protected]>
Date:   Wed Jan 24 09:34:50 2024 +0100

    Merge pull request #100 from KomodoPlatform/dev

    sync master

commit 68138a3
Merge: b0eb54a 36c6afd
Author: Kadan Stadelmann <[email protected]>
Date:   Tue Jan 16 12:59:34 2024 +0100

    Merge pull request #93 from KomodoPlatform/dev

    sync master

commit b0eb54a
Merge: 8281a1a b4d69d1
Author: Kadan Stadelmann <[email protected]>
Date:   Wed Dec 20 00:53:07 2023 +0100

    Merge pull request #91 from KomodoPlatform/dev

    `0.9.0` RC - Net ID migration and file sharing fixes

commit 8281a1a
Author: smk762 <[email protected]>
Date:   Mon Oct 30 16:42:47 2023 +0800

    update rates url

commit 40b1eb2
Merge: 0f30d51 e32aff7
Author: Charl <[email protected]>
Date:   Fri Oct 20 18:38:35 2023 +0200

    0.8.0 Release: Merge pull request #78 from KomodoPlatform/dev

    0.8.0 Release (stable): UI revamp, bug fixes and coins update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9.0 v0.9.0 release: Net ID migration and order book + file export bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants