-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync v0.9.0 dev into digibyte #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the coin updater more robust to exceptions thrown during updating/loading coins config data and improve logging for the loading process. The aim of this is to possibly solve the reported issues of the production app crashing (for a minority of users) when MM2 is launched.
Refactor `share` to `share_plus` and add home page log export by tapping app logo 7 times.
Sync the iOS counterparts of the changed Dart dependencies.
Throw an exception in the logs layer if there are no exported log files to share. Catch the error and show a snackbar.
GZip is the final compression algorithm used, so the file extension should be `.gz`.
Even though coin config files are updated at runtime, it’s a good idea to keep the bundled version up to date since it’s used on the first launch and is used as a fallback if update fails. NB: In the near future, these files will be dropped from the repo and instead rather fetched at CI build time in PR #87 (#87).
Major release version because net ID update is a breaking change since users on old net ID cannot see order book of new net ID users. This is part of a p2p network stack upgrade for Komodo DeFi framework which opens up future possibilities for more efficient streaming-based event features.
The new Komodo DeFi Framework p2p layer changes require Android NDK >=23.
Fix file sharing export & log refactoring
Update netid, coins and bump app version
Fix - Order book showing incorrect values
Update coin config for critical coins config update. Update coins config and icon files to commit 26641cc1fef362063aa4e394dba8b82e7ebaf2cf of `KomodoPlatform/coins`. NB: In the near future, the coin icon and config files will be removed from the repo and fetched and build time locally and in CI deployment using a Python script.
BTC -> BTC-segwit
ad111bd842cdc6a6f0f0dcb55abcde7e56c3e266
Sync KomodoPlatform/coins config+icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.