Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swap steps hanging #99

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix swap steps hanging #99

merged 2 commits into from
Jan 24, 2024

Conversation

naezith
Copy link
Collaborator

@naezith naezith commented Jan 23, 2024

Solves #98

  • Some swap states had different JSON structure that were unexpected for the front-end code. It was receiving an Array instead of Map at some events.
  • MakerPaymentSpentByWatcher was not recognized as a success step.

Needs good testing.

@naezith naezith requested review from ca333, CharlVS and kivqa January 23, 2024 12:30
@naezith naezith self-assigned this Jan 23, 2024
kivqa
kivqa approved these changes Jan 23, 2024
View reviewed changes
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Swap workflow works as expected. No regression was found.

@CharlVS CharlVS added bug Something isn't working QA Ready for QA review labels Jan 24, 2024
@CharlVS CharlVS merged commit 06947f9 into dev Jan 24, 2024
1 check failed
ca333 added a commit that referenced this pull request Jan 24, 2024
@ca333
Merge pull request #101 from KomodoPlatform/dev
eee6637 
Fix swap steps hanging (#99)
@takenagain takenagain mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kivqa kivqa kivqa approved these changes

@CharlVS CharlVS CharlVS approved these changes

@ca333 ca333 Awaiting requested review from ca333

Assignees

@naezith naezith

Labels
bug Something isn't working QA Ready for QA review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naezith @CharlVS @kivqa