build: fix build on xenial (16.04) #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without -fPIC for libcryptoconditions_core.a build will end with error below on Xenial: ``` /usr/bin/ld: cryptoconditions/libcryptoconditions_core.a(libcryptoconditions_core_a-cryptoconditions.o): relocation R_X86_64_32 against `.text' can not be used when making a shared object; recompile with -fPIC cryptoconditions/libcryptoconditions_core.a: error adding symbols: Bad value collect2: error: ld returned 1 exit status ```
ca333
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the build issue on
Xenial (Ubuntu 16.04). Officially, we do not support it as it has reached its End of Life (EOL). However, since building under Xenial is still possible, it might be a good idea to fix it. Moreover, binaries built under Xenial should also function on higher versions of Ubuntu / Linux distributions with a higher LIBC version.Without -fPIC for libcryptoconditions_core.a build will end with error below on Xenial: