feat: Service Catalog GitLab integration #8329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudjumpercat
added
do not merge
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cloudjumpercat
force-pushed
the
service-catalog-gitlab
branch
from
b70beab to
4da3a20
Compare
|
LGTM, thank you @cloudjumpercat! |
| * Merged merge requests | ||
|
|
||
|
|
||
| ## Discovery information |
There was a problem hiding this comment.
suggestion: there's info here that's not user-facing and some that's no longer relevant (cc @miko-bautista)
- There's no concept of "enabled" for integration discovery in KSC
Bindable entitiesis close tobindingwhich is a term we're trying to move away from externally. Instead, use "Resources" and/or "Resource Types"- "Discovery mechanism" is not a user-facing detail
I think this section can be as concise as:
GitLab Projects will be automatically discovered once the integration is authorized.
Rest of the docs look great! 🙂
There was a problem hiding this comment.
@Drew-Kimberly Thanks for the feedback! Since this is reusable content that is used by multiple integrations, I removed the 1st and 4th bullets, and reworded the remaining two per your suggestions.
Signed-off-by: Diana <[email protected]>
Signed-off-by: Diana <[email protected]>
Signed-off-by: Diana <[email protected]>
cloudjumpercat
force-pushed
the
service-catalog-gitlab
branch
from
9a21814 to
5bb924b
Compare
…ns to GitLab docs Signed-off-by: Diana <[email protected]>
miko-bautista
approved these changes
Jan 22, 2025
cloudjumpercat
added
review:copyedit
Guaris
approved these changes
Jan 24, 2025
Guaris
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added GitLab as the newest Service Catalog integration.
DOCU-4140
Testing instructions
Preview link: https://deploy-preview-8329--kongdocs.netlify.app/konnect/service-catalog/integrations/gitlab/
Checklist