Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in KIC image tag #8392

Closed
wants to merge 1 commit into from
Closed

fix typo in KIC image tag #8392

wants to merge 1 commit into from

Conversation

lena-larionova
Copy link
Contributor

Description

Fixes #8304

Testing instructions

Preview link:

Checklist

@lena-larionova lena-larionova added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Jan 30, 2025
@lena-larionova lena-larionova requested a review from a team as a code owner January 30, 2025 16:51
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 62d20ef
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/679bae101780a700082f323d
😎 Deploy Preview https://deploy-preview-8392--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 76 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 98 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -156,7 +156,7 @@ spec:
spec:
containers:
- name: proxy
image: kong:{{ site.data.kong_latest_gateway.ce-version }}
image: kong/kong:{{ site.data.kong_latest_gateway.ce-version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a typo. kong is the official image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the user had issues pulling it this way: #8304

I can close this if it's due to environment problems instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's due to the environment

@lena-larionova lena-larionova deleted the fix/kic-image-tag branch January 30, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to deploy due to uncorrect Image Tag
2 participants