Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin examples portal app reg #8417

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

mheap
Copy link
Member

@mheap mheap commented Feb 10, 2025

Description

Two fixes:

  • Detect schema compatibility correctly (missing key and null were being evaluated as the same)
  • Add support for overriding a basic plugin example when it's an auto-configured plugin

Testing instructions

Preview link: /hub/kong-inc/application-registration/how-to/basic-example/

Checklist

@mheap mheap added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Feb 10, 2025
@mheap mheap marked this pull request as ready for review February 10, 2025 15:41
@mheap mheap requested a review from a team as a code owner February 10, 2025 15:41
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 7bd40c5
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/67ab5e3ba556f80008e036ac
😎 Deploy Preview https://deploy-preview-8417--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 92 (🟢 up 3 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lena-larionova lena-larionova marked this pull request as draft February 10, 2025 18:52
@mheap mheap force-pushed the plugin-examples-portal-app-reg branch from f8a7e1a to b512abb Compare February 11, 2025 11:05
@mheap mheap marked this pull request as ready for review February 11, 2025 14:22
@lena-larionova lena-larionova merged commit 9ffd6e9 into main Feb 11, 2025
16 checks passed
@lena-larionova lena-larionova deleted the plugin-examples-portal-app-reg branch February 11, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants