Skip to content

Commit

Permalink
fix(shell): change prefix for health checks
Browse files Browse the repository at this point in the history
Since Pongo sets the prefix to use to `/kong-plugin/servroot/` the
healthchecks would always fail because they would check in the
default location. This fixes them.

Health is ok, if Kong is running in the container.
So in case of a `pongo shell` it is unhealthy until Kong is started.
  • Loading branch information
Tieske committed Oct 31, 2023
1 parent fc44994 commit f07e363
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,13 @@ The result should be a new PR on the Pongo repo.
---
## unreleased
* Fix: health-checks on Pongo container. Use proper prefix.
[#456](https://github.com/Kong/kong-pongo/pull/456).
---
## 2.8.0 released 24-Oct-2023
* Fix: `pongo down` would not remove volumes. This
Expand Down
10 changes: 10 additions & 0 deletions assets/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,16 @@ services:
- PONGO_COMMAND=${ACTION}
- PONGO_NETWORK=${SERVICE_NETWORK_NAME}
- PONGO_ID=${PROJECT_ID}
healthcheck:
interval: 5s
retries: 10
test:
- CMD
- kong
- health
- --prefix=/kong-plugin/servroot/
timeout: 10s
disable: ${SERVICE_DISABLE_HEALTHCHECK:-false}
networks:
pongo-test-network:
aliases:
Expand Down

0 comments on commit f07e363

Please sign in to comment.