Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(expose): remove the cassandra ports from 'expose' #455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@

---

## unreleased
## 3.0.0 unreleased

* BREAKING: `pongo expose` will no longer expose the Cassandra ports. This fixes
an [issue with ports in use](https://developer.apple.com/forums/thread/682332) on MacOS.
This will have an impact only if you use Cassandra AND directly access Cassandra
by exposing the ports using `pongo expose` and then connect to the Cassandra DB directly.
[#455](https://github.com/Kong/kong-pongo/pull/455).

* Fix: include the Pongo version in the generated image names to prevent running
older images after a Pongo upgrade. A new image will automatically be build now.
Expand Down
8 changes: 1 addition & 7 deletions assets/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,11 @@ services:
- "8445:8445"
# Postgres
- "5432:5432"
# Cassandra
- "7000:7000"
- "7001:7001"
- "7199:7199"
- "9042:9042"
- "9160:9160"
# Redis
- "6379:6379"
- "6380:6380"
environment:
EXPOSE: "kong:8000 kong:8001 kong:8002 kong:8003 kong:8004 kong:8443 kong:8444 kong:8445 postgres:5432 cassandra:7000 cassandra:7001 cassandra:7199 cassandra:9042 cassandra:9160 redis:6379 redis:6380"
EXPOSE: "kong:8000 kong:8001 kong:8002 kong:8003 kong:8004 kong:8443 kong:8444 kong:8445 postgres:5432 redis:6379 redis:6380"
healthcheck:
interval: 5s
retries: 10
Expand Down
1 change: 0 additions & 1 deletion assets/help/expose.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ dependency.
Ports:
- Kong : 8000, 8001, 8002, 8003, 8004, 8443, 8444, 8445
- Postgres : 5432
- Cassandra: 7000, 7001, 7199, 9042, 9160
- Redis : 6379, 6380


Expand Down
Loading