feat: support access to host runner's services #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
requested changes
Nov 20, 2023
|
@Tieske sure. Let me do. |
By default, workflows run on a Linux OS. For containers to access to host services, we should update the docker compose file to include 'host.docker.internal' This would significantly reduce the number of containers and resources required for EE plugins tests.
outsinre
force-pushed
the
access-to-host-services
branch
from
f31a90a
to
d43f98a
Compare
outsinre
changed the title
outsinre
changed the title
Tieske
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, workflows run on a Linux OS. For containers to access to host services, we should update the docker compose file to include
host.docker.internal.This would significantly reduce the number of containers and resources required for EE plugins tests.
Refs: https://stackoverflow.com/a/62431165/2336707