-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(prometheus): add a toggle switch for wasm metrics export #13960
base: master
Are you sure you want to change the base?
Conversation
@fffonion can you let me know if this is what you were looking for? It is not possible to control export on a per service/route basis for Wasm. It's a little weird putting a global toggle into a configuration field that is not global, but from what I can tell we're doing something similar with |
@flrgh yes, I think a plugin side of config like this is fine 👍. prometheus is still a plugin not a first class component in kong so putting into kong.conf is indeed weird. |
51b54a7
to
461e25a
Compare
note: has manual backport/cherry-pick PRs already:
|
461e25a
to
0da5508
Compare
0da5508
to
da7ae80
Compare
cdbc20e
to
19451b6
Compare
19451b6
to
f75f425
Compare
f75f425
to
1feeec4
Compare
Summary
Adds a toggle for wasm metrics export to the prometheus plugin.
Issue reference
KAG-5904