Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clustering/sync): fix delta not using absolute TTL #14264

Closed
wants to merge 9 commits into from
Closed

fix(clustering/sync): fix delta not using absolute TTL #14264

wants to merge 9 commits into from
+49 −3

Conversation

Oyami-Srk
Copy link
Member

@Oyami-Srk Oyami-Srk commented Feb 12, 2025 •
edited
Loading

Summary

The reason for not making SQL write statements returning absolute value is for the compatibility of other parts of code.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-6296

@Oyami-Srk Oyami-Srk marked this pull request as draft February 12, 2025 04:06
@github-actions github-actions bot added core/clustering core/db cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Feb 12, 2025
@Oyami-Srk Oyami-Srk marked this pull request as ready for review February 12, 2025 07:04
@Oyami-Srk Oyami-Srk changed the title [WIP] fix(clustering/sync): fix delta not using absolute TTL fix(clustering/sync): fix delta not using absolute TTL Feb 12, 2025
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/rpc-sync-ttl branch 2 times, most recently from 2fb3f5a to 357f6f2 Compare February 17, 2025 06:13
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/rpc-sync-ttl branch 2 times, most recently from 77c0522 to 52f82ae Compare February 18, 2025 02:12
@Oyami-Srk Oyami-Srk force-pushed the haoxuan/rpc-sync-ttl branch from 52f82ae to 169c3f8 Compare February 18, 2025 02:13
@chronolaw chronolaw closed this Feb 18, 2025
@Oyami-Srk Oyami-Srk deleted the haoxuan/rpc-sync-ttl branch February 18, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw left review comments

Assignees

@Oyami-Srk Oyami-Srk

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering core/db size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oyami-Srk @chronolaw