fix(pdk): make kong.service.request.clear_query_arg encode spaces as %20 instead of + #14277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…%20 instead of + ### Summary The `+` encoding is more correct (in query strings), but it seems to cause some problems with some users. As a short-term solution I propose that we just convert `+` to `%20`. This is more in-lines what Nginx and OpenResty seems to be doing as well. Signed-off-by: Aapo Talvensaari <[email protected]>
github-actions
bot
added
core/pdk
cherry-pick kong-ee
bungle
removed
the
cherry-pick kong-ee
samugi
approved these changes
Feb 14, 2025
brentos
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
+encoding is more correct (in query strings), but it seems to cause some problems with some users. As a short-term solution I propose that we just convert+to%20. This is more in-lines what Nginx and OpenResty seems to be doing as well.KAG-6324
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdThere is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREIssue reference
Fix FTI-6475