chore: refactor crd validation tests to deduplicate boilerplate #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactors the tests under
test/crdsvalidation
to deduplicate the boilerplate needed for every single CRD type. This pattern of testing proved to be flexible enough to run any scenario we wanted to check, therefore I think it's worth extracting this as a common suite type.What has been done:
crdname_test.go
file undertests/crdsvalidation
CRDValidationTestCasesGroup
CRDValidationTestCasesGroup
What hasn't been done (aka excuses for the changes volume):
<CRDName>
field in the test case toTestObject
<CRDName>Status
contents from test cases that had it to theTestObject
itselfWhich issue this PR fixes
Enabler for #29.