[release/1.0.x]: allow konnectID on ControlPlaneRef, disallow in types that include it
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
changed the title
konnectID on ControlPlaneRef, disallow in types that include it
pmalek
force-pushed
the
1.0.x/konnectID
branch
from
b471925 to
fbfd68d
Compare
pmalek
force-pushed
the
1.0.x/konnectID
branch
from
fbfd68d to
c091b28
Compare
czeslavo
reviewed
Jan 22, 2025
czeslavo
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes sure that
konnectIDcp ref is allowed onControlPlaneReftype but is limited where embedded.This allows types like KGO's
KonnectExtensionto still be able to use it.Which issue this PR fixes
Fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes