feat(konnect): add KonnectCloudGatewayNetwork CRD #268
+1,383
−424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
konnect-network-type
branch
8 times, most recently
from
bf37118 to
6bd0f36
Compare
pmalek
force-pushed
the
konnect-network-type
branch
from
6bd0f36 to
256b322
Compare
mlavacca
reviewed
Feb 5, 2025
pmalek
force-pushed
the
konnect-network-type
branch
2 times, most recently
from
ed4b9d3 to
709e6a7
Compare
pmalek
changed the title
pmalek
force-pushed
the
konnect-network-type
branch
3 times, most recently
from
10abde0 to
107b2d4
Compare
pmalek
commented
Feb 7, 2025
mlavacca
approved these changes
Feb 7, 2025
pmalek
force-pushed
the
konnect-network-type
branch
5 times, most recently
from
31a2f0f to
f5c6c4f
Compare
mlavacca
reviewed
Feb 13, 2025
pmalek
force-pushed
the
konnect-network-type
branch
from
0d0a2aa to
0912241
Compare
Co-authored-by: Mattia Lavacca <[email protected]>
pmalek
force-pushed
the
konnect-network-type
branch
from
f1fdcd1 to
035c54d
Compare
mlavacca
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Maps https://docs.konghq.com/konnect/api/cloud-gateways/latest/#/Networks/create-network API.
Ref:
This PR doesn't add any specific validations for network fields.After a discussion with @kevinwilson541, this API has been made immutable as networks in Konnect are considered as such.
Which issue this PR fixes
Fixes #269
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes