Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use 1pass to access konnect PAT for tests #6752

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Dec 2, 2024

What this PR does / why we need it:

Use https://github.com/1Password/load-secrets-action to get Konnect PAT for tests directly from 1password's vault.

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the area/ci label Dec 2, 2024
@pmalek pmalek self-assigned this Dec 2, 2024
@pmalek pmalek force-pushed the 1pass-konnect-pat branch 2 times, most recently from 34fcf28 to deb42cc Compare December 2, 2024 16:28
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (bebebfb) to head (ac7cd01).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6752     +/-   ##
=======================================
+ Coverage   77.8%   79.0%   +1.2%     
=======================================
  Files        207     207             
  Lines      24621   24621             
=======================================
+ Hits       19156   19454    +298     
+ Misses      4491    4176    -315     
- Partials     974     991     +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek force-pushed the 1pass-konnect-pat branch from 9ea35a8 to ac7cd01 Compare December 4, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant