Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't use KonnectClient in ClientsProvider #6885

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Dec 20, 2024

What this PR does / why we need it:

Stop using KonnectClient in the clients' provider. Make konnect.ConfigSynchronizer create one using a factory on its startup instead. Also:

  • moves tests related to Konnect-specific behavior to konnect.ConfigSynchronizer.
  • moves call to deckgen.ToDeckContent from KongClient to konnect.ConfigSynchronizer as it may reach out to Konnect APIs while for plugins schemas, and we don't want to spend time on Konnect-related stuff in the critical path

Which issue this PR fixes:

Part of #6340.

@czeslavo czeslavo self-assigned this Dec 20, 2024
@czeslavo czeslavo added area/konnect Issues and PRs related to Konnect and removed size/XL labels Dec 20, 2024
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch 4 times, most recently from ba03ed5 to 7b8e093 Compare December 23, 2024 09:29
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 10.34483% with 26 lines in your changes missing coverage. Please review.

Project coverage is 4.0%. Comparing base (b14df00) to head (592d5dd).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/adminapi/konnect.go 0.0% 14 Missing ⚠️
internal/dataplane/sendconfig/dbmode.go 30.0% 6 Missing and 1 partial ⚠️
internal/util/clock/ticker.go 0.0% 4 Missing ⚠️
internal/dataplane/sendconfig/strategy.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #6885      +/-   ##
========================================
- Coverage   59.0%    4.0%   -55.1%     
========================================
  Files        210     138      -72     
  Lines      25241   15141   -10100     
========================================
- Hits       14917     606   -14311     
- Misses      9030   14465    +5435     
+ Partials    1294      70    -1224     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch 4 times, most recently from a9d2248 to 984e8a6 Compare December 23, 2024 14:56
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch from 984e8a6 to 1d7e311 Compare December 23, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/konnect Issues and PRs related to Konnect size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant