Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): harden GITHUB_TOKEN permissions #6961

Merged
merged 5 commits into from
Jan 14, 2025
Merged

chore(ci): harden GITHUB_TOKEN permissions #6961

merged 5 commits into from
Jan 14, 2025

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jan 14, 2025

What this PR does / why we need it:

This PR should mitigate the https://github.com/Kong/kubernetes-ingress-controller/security/code-scanning?query=is%3Aopen+branch%3Amain+Token-Permissions code scanning alerts.

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the area/ci label Jan 14, 2025
@pmalek pmalek added this to the KIC v3.5.x milestone Jan 14, 2025
@pmalek pmalek self-assigned this Jan 14, 2025
@pmalek pmalek marked this pull request as ready for review January 14, 2025 10:48
@pmalek pmalek requested a review from a team as a code owner January 14, 2025 10:48
@pmalek pmalek enabled auto-merge (squash) January 14, 2025 10:48
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.8%. Comparing base (d4d18a4) to head (2a156af).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6961     +/-   ##
=======================================
- Coverage   76.9%   76.8%   -0.1%     
=======================================
  Files        214     214             
  Lines      25169   25169             
=======================================
- Hits       19356   19350      -6     
- Misses      4794    4809     +15     
+ Partials    1019    1010      -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek added the ci/run-e2e Trigger e2e test run from PR label Jan 14, 2025
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12767774179

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jan 14, 2025
@pmalek pmalek merged commit 6507cd6 into main Jan 14, 2025
163 checks passed
@pmalek pmalek deleted the token-permissions branch January 14, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants