chore: ensure logger is passed down #7072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/kic-as-library #7072 +/- ##
=====================================================
Coverage ? 76.7%
=====================================================
Files ? 219
Lines ? 25055
Branches ? 0
=====================================================
Hits ? 19226
Misses ? 4817
Partials ? 1012 ☔ View full report in Codecov by Sentry. |
programmer04
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Where possible, it leverages
ctrl.LoggerFrom(ctx)instead of passing the logger explicitly. Besides that, there was no further improvement needed to pass the parent logger down.Which issue this PR fixes:
Closes #7045.