Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decouple diagnostics server from collector and handlers #7079

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 4, 2025

What this PR does / why we need it:

Refactors the diagnostics.Server by splitting it into a Collector, Handler, and a Server. That will be needed to enable plugging multiple instances of an HTTPHandler into one mux when we run multiple instances of the manager.

Which issue this PR fixes:

Part of #7042.

@czeslavo czeslavo force-pushed the chore/pluggable-diagnostics-server branch from a5ca7cb to 8aef011 Compare February 5, 2025 16:35
@czeslavo czeslavo force-pushed the chore/pluggable-diagnostics-server branch 3 times, most recently from adde072 to 7af6dbd Compare February 5, 2025 16:47
@czeslavo czeslavo changed the title chore: make diagnostics server pluggable chore: decouple diagnostics server from collector and handlers Feb 5, 2025
@czeslavo czeslavo self-assigned this Feb 5, 2025
@czeslavo czeslavo added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label Feb 5, 2025
@czeslavo czeslavo force-pushed the chore/pluggable-diagnostics-server branch 2 times, most recently from ed544af to 726556e Compare February 5, 2025 16:57
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 85.54572% with 49 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/kic-as-library@c317a2b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/diagnostics/http_handler.go 74.1% 22 Missing and 8 partials ⚠️
internal/diagnostics/collector.go 88.6% 11 Missing and 1 partial ⚠️
internal/manager/run.go 87.5% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/kic-as-library   #7079   +/-   ##
=====================================================
  Coverage                       ?   77.0%           
=====================================================
  Files                          ?     216           
  Lines                          ?   24990           
  Branches                       ?       0           
=====================================================
  Hits                           ?   19262           
  Misses                         ?    4730           
  Partials                       ?     998           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the chore/pluggable-diagnostics-server branch 8 times, most recently from 37ae266 to 41b9066 Compare February 6, 2025 10:31
@czeslavo czeslavo marked this pull request as ready for review February 6, 2025 10:42
@czeslavo czeslavo requested a review from a team as a code owner February 6, 2025 10:42
@czeslavo czeslavo force-pushed the chore/pluggable-diagnostics-server branch from 41b9066 to d85df25 Compare February 6, 2025 13:10
@czeslavo czeslavo merged commit 5eb1c6c into feat/kic-as-library Feb 6, 2025
41 checks passed
@czeslavo czeslavo deleted the chore/pluggable-diagnostics-server branch February 6, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants