fix: tile header overflow issue #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adorack
requested changes
Feb 7, 2025
| const titleRef = ref<HTMLElement>() | ||
| const isTitleTruncated = ref(false) | ||
|
|
||
| onMounted(async () => { |
There was a problem hiding this comment.
This needs to be a watch; it's possible for the title to change without the tile getting unmounted.
filipgutica
force-pushed
the
fix/tile-header-overflow
branch
from
f5af990 to
46b02cc
Compare
filipgutica
force-pushed
the
fix/tile-header-overflow
branch
from
701c7b7 to
1cda35e
Compare
adorack
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/MA-3645
Also add a tooltip when title is truncated