1주차 미션 / 서버 3조 장익환 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmw10693
reviewed
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
미션 요구사항2는 시간이 부족해서 시도해보는데 그쳤지만, 미션 요구사항1인 리팩토링까지는 겨우 했습니다. 테스트 코드를 수정해서 기능이 동작하는지도 확인해보았습니다. 이전에는 자바 코드를 작성할 때 고민이 부족했던 것 같습니다. 하지만 이번 과제를 통해서 원시값과 유효성 검증을 하나의 클래스로 묶는 습관을 들여야 겠다고 생각했습니다. 그리고 한 클래스에 책임이 과중되지 않도록 책임을 여러 클래스에 분산시켜야 한다는 점을 배울 수 있었습니다. 미션 결과를 확인해주셔서 감사합니다.