3주차 미션 / 서버 3조 김나은 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JangIkhwan
reviewed
Oct 7, 2024
Comment on lines
+21
to
+25
| String body = request.getBody(); | ||
| Map<String, String> params = HttpRequestUtils.parseQueryParameter(body); | ||
|
|
||
| String userId = params.get(USER_ID.getKey()); | ||
| String password = params.get(PASSWORD.getKey()); |
There was a problem hiding this comment.
파라미터를 파싱하는 걸 컨트롤러 대신에 httpRequest에서 처리하는 것도 괜찮을 것 같아요.
Comment on lines
+17
to
+27
| public static HttpRequest from(BufferedReader br) throws IOException { | ||
| String startLine = br.readLine(); | ||
| HttpRequestStartLine httpStartLine = HttpRequestStartLine.from(startLine); | ||
|
|
||
| HttpRequestHeaders httpHeaders = HttpRequestHeaders.from(br); | ||
|
|
||
| int contentLength = httpHeaders.getContentLength(); | ||
| HttpRequestBody httpBody = HttpRequestBody.from(br, contentLength); | ||
|
|
||
| return new HttpRequest(httpStartLine, httpHeaders, httpBody); | ||
| } |
|
|
||
| import static http.HttpHeader.*; | ||
|
|
||
| public class HttpRequestHeaders { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.