5주차 미션 / 서버 3조 이윤희 #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JangIkhwan
reviewed
Nov 9, 2024
Comment on lines
-12
to
+25
| return "/home.jsp"; | ||
|
|
||
| List<Question> questions = questionDao.findAll(); | ||
| req.setAttribute("questions", questions); | ||
|
|
||
| RequestDispatcher rd = req.getRequestDispatcher("/home.jsp"); | ||
| rd.forward(req, resp); | ||
|
|
||
| return null; |
There was a problem hiding this comment.
여기서 forward를 안해도 됩니다...! /home.jsp를 리턴하면 DispatcherServlet이 forward를 해줘요
Comment on lines
+9
to
+27
| public class ControllerUtils { | ||
|
|
||
| public static Question getQuestionAndCheckAuthorization(HttpServletRequest req, QuestionDao questionDao) throws Exception { | ||
|
|
||
| User user = (User) req.getSession().getAttribute("user"); | ||
| if (user == null) { | ||
| throw new IllegalStateException("로그인이 필요합니다."); | ||
| } | ||
|
|
||
| int questionId = Integer.parseInt(req.getParameter("questionId")); | ||
| Question question = questionDao.findByQuestionId(questionId); | ||
|
|
||
| if (!user.getUserId().equals(question.getWriter())) { | ||
| throw new IllegalArgumentException("수정 권한이 없습니다."); | ||
| } | ||
|
|
||
| return question; | ||
| } | ||
| } |
There was a problem hiding this comment.
개인적인 견해로는 Controller 클래스가 이 작업을 수행하는 것이 좋을 것 같아요
|
|
||
| public class CreateQnaController implements Controller { | ||
|
|
||
| private final QuestionDao questionDao = new QuestionDao(); |
There was a problem hiding this comment.
지금은 필드주입으로 충분하지만 장기적인 관점에서 보면 생성자 주입을 사용하는 것이 더 좋을 것 같네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제 webMVC repository를 삭제해버려서,, 다시 올립니당 ㅜ