Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map/Set trie node canonicalization #53

Closed
wants to merge 0 commits into from
Closed

Map/Set trie node canonicalization #53

wants to merge 0 commits into from

Conversation

qurbonzoda
Copy link
Contributor

@qurbonzoda qurbonzoda commented Aug 9, 2019 •
edited
Loading

#52 should be merged first

@qurbonzoda qurbonzoda requested a review from ilya-g August 9, 2019 18:14
@qurbonzoda qurbonzoda force-pushed the trie-node-canonicalization branch 4 times, most recently from 8111d6a to 82a9db3 Compare August 16, 2019 05:36
@qurbonzoda qurbonzoda force-pushed the trie-node-canonicalization branch from 82a9db3 to c8cb305 Compare September 20, 2019 00:27
@qurbonzoda qurbonzoda force-pushed the trie-node-canonicalization branch 3 times, most recently from fe8ff0a to 8dc8c13 Compare October 7, 2019 21:28
@qurbonzoda
Copy link
Contributor Author

Only canonicalization benchmarks: https://teamcity.jetbrains.com/viewLog.html?buildId=2579755&buildTypeId=KotlinTools_KotlinxCollectionsImmutableArchive_BenchmarkHashIterations&tab=artifacts

Other benchmarks: https://teamcity.jetbrains.com/viewLog.html?buildId=2576447&buildTypeId=KotlinTools_KotlinxCollectionsImmutableArchive_BenchmarkHashIterations&tab=artifacts

ilya-g
ilya-g approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@ilya-g ilya-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ascii-art diagrams in HashMapTrieNodeTest

@qurbonzoda qurbonzoda force-pushed the trie-node-canonicalization branch from 8dc8c13 to 59ac6e5 Compare October 9, 2019 16:36
@qurbonzoda qurbonzoda closed this Oct 9, 2019
@qurbonzoda qurbonzoda force-pushed the trie-node-canonicalization branch from 59ac6e5 to 2036d5e Compare October 9, 2019 16:43
@qurbonzoda qurbonzoda deleted the trie-node-canonicalization branch August 24, 2020 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-g ilya-g ilya-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qurbonzoda @ilya-g