Merge pull request #555 from Kraigie/jb3/nuke-channel-cache

Nuke the ChannelCache from existence
Kraigie · Apr 19, 2024 · 984e052 · 984e052
2 parents a72d725 + e6e1b07
commit 984e052
Show file tree

Hide file tree

Showing 11 changed files with 19 additions and 574 deletions.
diff --git a/examples/cache.ex b/examples/cache.ex
@@ -32,7 +32,7 @@ defmodule ExampleCommands do
   import Nostrum.Snowflake, only: [is_snowflake: 1]
 
   alias Nostrum.Api
-  alias Nostrum.Cache.{ChannelCache, GuildCache, UserCache}
+  alias Nostrum.Cache.{GuildCache, UserCache}
   alias Nostrum.Struct.User
 
   # Fetch the defined prefix from our config, however,
@@ -66,15 +66,12 @@ defmodule ExampleCommands do
            {Integer.parse(message_user_id), :parse_id},
          {:ok, user} <-
            get_cached_with_fallback(user_id, &UserCache.get/1, &Api.get_user/1),
-         {:ok, %{name: channel_name}} <-
-           get_cached_with_fallback(channel_id, &ChannelCache.get/1, &Api.get_channel/1),
          {:ok, %{name: guild_name}} <-
            get_cached_with_fallback(guild_id, &GuildCache.get/1, &Api.get_guild/1) do
       Api.create_message(
         channel_id,
         """
         ID #{message_user_id} belongs to: #{User.full_name(user)}
-        Message sent in channel: ##{channel_name}
         Channel belongs to guild: #{guild_name}
         """
       )

diff --git a/lib/nostrum/cache/cache_supervisor.ex b/lib/nostrum/cache/cache_supervisor.ex
@@ -4,9 +4,9 @@ defmodule Nostrum.Cache.CacheSupervisor do
 
   See the documentation for the relevant submodules for details:
 
-  - `Nostrum.Cache.ChannelCache`
   - `Nostrum.Cache.GuildCache`
   - `Nostrum.Cache.Me`
+  - `Nostrum.Cache.MemberCache`
   - `Nostrum.Cache.PresenceCache`
   - `Nostrum.Cache.UserCache`
   """
@@ -25,7 +25,6 @@ defmodule Nostrum.Cache.CacheSupervisor do
       Nostrum.Cache.GuildCache,
       Nostrum.Cache.MemberCache,
       Nostrum.Cache.UserCache,
-      Nostrum.Cache.ChannelCache,
       Nostrum.Cache.PresenceCache
     ]
 

diff --git a/lib/nostrum/cache/channel_cache.ex b/lib/nostrum/cache/channel_cache.ex
diff --git a/lib/nostrum/cache/channel_cache/ets.ex b/lib/nostrum/cache/channel_cache/ets.ex