Border class and registry #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polypoyo
force-pushed
the
kristal/border-registry
branch
from
a60738d
to
cda18c7
Compare
Should clarify that I mean I tested that those work without modification. |
|
Make sure to also change the borders debug menu to use the registry instead of manually searching: |
|
Thanks for bringing that to my attention! For now, it will check both the files and the registry. |
|
nvm, it's intentional |
FireRainV
reviewed
Nov 7, 2024
polypoyo
force-pushed
the
kristal/border-registry
branch
from
748299e
to
9bc5d95
Compare
|
Does this break backwards compatibility? |
AFAIK no. I've tested with Dark Place Legacy's animated borders (KRISTAL_EVENT.onBorderDraw), and those are fine. Also tested with image borders in StarRune |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to split up your custom borders. Tested with
glowandbattleborders in Dark Place Legacy.