Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multicluster tests #604

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix multicluster tests #604

merged 1 commit into from
Dec 4, 2024

Conversation

averevki
Copy link
Contributor

No description provided.

@averevki
Fix multicluster tests
91e5831 
Signed-off-by: averevki <[email protected]>
@averevki averevki added the bug Something isn't working label Nov 21, 2024
@averevki averevki requested review from trepel and azgabur November 21, 2024 17:18
trepel
trepel approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed with eng what the changes here do is expected behavior. Code looks good to me. Tests are passing against v1. Approving.

@jsmolar jsmolar merged commit 133b244 into Kuadrant:main Dec 4, 2024
3 checks passed
@averevki averevki deleted the fix-multicluster-tests branch January 20, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trepel trepel trepel approved these changes

@jsmolar jsmolar jsmolar approved these changes

@azgabur azgabur Awaiting requested review from azgabur

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averevki @trepel @jsmolar