Test for changing parentRef field in policies (AuthPolicy and RateLimitPolicy) #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmaaroche
force-pushed
the
test-change-parentref
branch
2 times, most recently
from
db28248 to
4dbcc75
Compare
…itPolicy) Signed-off-by: emmaaroche <[email protected]>
emmaaroche
force-pushed
the
test-change-parentref
branch
from
4dbcc75 to
5edc14b
Compare
averevki
reviewed
Jan 27, 2025
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
Signed-off-by: emmaaroche <[email protected]>
emmaaroche
force-pushed
the
test-change-parentref
branch
from
b807697 to
d66e9b5
Compare
Signed-off-by: emmaaroche <[email protected]>
averevki
reviewed
Feb 6, 2025
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_authpolicy_target_ref.py
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_authpolicy_target_ref.py
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_authpolicy_target_ref.py
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_authpolicy_target_ref.py
Show resolved
Hide resolved
|
|
||
| response = client.get("/get", auth=auth) | ||
| assert response.status_code == 200 | ||
|
|
There was a problem hiding this comment.
Check also that requests won't go through without the auth, and authpolicy is truly enforced. You can also verify that second gateway is not protected by authpolicy before you switch it.
| responses = client.get_many("/get", 5, auth=auth) | ||
| responses.assert_all(status_code=200) | ||
| assert client.get("/get", auth=auth).status_code == 429 | ||
|
|
There was a problem hiding this comment.
Same here, you could check that second gateway is not limiting any requests before you switch it
testsuite/tests/singlecluster/gateway/reconciliation/test_update_ratelimitpolicy_target_ref.py
Show resolved
Hide resolved
There was a problem hiding this comment.
There is a lot of code duplicity in these tests. I'm wondering if we can create a separate package with its own conftest for this. You can put duplicate fixtures there.
In the future we will need to create the same tests for DNS and TLS policies, so they can go to the same place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for changing parentRef field in policies (AuthPolicy and RateLimitPolicy)