Add a custom content provider that can download icons #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, it looks like a clean solution. I will test and look at the code in more detail when I have time, the content provider solution is a very good idea. |
|
@J-Jamet Did you have time to take a look at it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a way to load icons from Web and from apps installed on device.
In order to not require the
INTERNETpermission and to not bloat KeePassDX itself with this logic, a new helper app has been created that does all the heavy lifting related to the icon loading and parsing. Currently, DuckDuckGo and Google is used to search for icons of the given URLs.The data is exposed via a custom
ContentProviderthat KeePassDX queries to show a list of related icons that can be imported into the database.I tried to keep the changes in the app to a minimum, but it required some changes in order to propagate the URLs and AndroidApp fields into the IconPicker such that it can query the content provider with this information.
Closes #596