Feat: school aliasing (LA <-> Los Angeles) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with this issue from #72:
I added an aliasing step in
clean-school-data-tap.js, wherein anything with substring 'LA' or 'Los Angeles' will be given an 'alias' key with 'LA' written out as 'Los Angeles', or vice-versa. This allows better searchability, because searching eg "east los angeles college" will now index on "East LA College", because it has an alias of "East Los Angeles College".Right now the only alias is LA <-> Los Angeles, but if there's any other aliases you'd like to include, feel free to add them in the
alias_mapinclean-school-data-tap.js.Just an aside, I also slightly modified the package-json curl request syntax because curl throws a fit if you use single-quotes on Windows (AKA my dev machine). I think my modified CURLS should run on all platforms, but feel free to get rid of that part of the pull if it causes any problems.