check for negative link traversal times and trip times #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test! |
JustinPihony
requested changes
Apr 10, 2022
src/main/scala/beam/analysis/cartraveltime/CarTripStatsFromPathTraversalEventHandler.scala
Show resolved
Hide resolved
src/main/scala/beam/analysis/cartraveltime/CarTripStatsFromPathTraversalEventHandler.scala
Outdated
Show resolved
Hide resolved
src/main/scala/beam/analysis/cartraveltime/CarTripStatsFromPathTraversalEventHandler.scala
Outdated
Show resolved
Hide resolved
|
Test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow negative/nan speeds have been occasionally making their way onto some links. This adds some simple filters, throws a warning if negative speeds make their way through, and makes sure that the automatically generated speed plots work.
This change is