Added a way to dynamically choose the x-range for orders by storing the locations in the database instead of hard coding. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he locations in the database instead of hard coding.
…evel columns in postgres.
sfoale
reviewed
Jan 13, 2025
| - The new location will become the current running location | ||
| - The old location will retain its good after date and set its good until to the good after of the new location | ||
| - The new range dates fall within a an exisiting range (good until != inf): | ||
| - We split the exisiting location, one with good after being the original good after and good until being the |
There was a problem hiding this comment.
Typos for example "within a an ..." and incorrect spelling of existing a few times in this doc string.
sfoale
approved these changes
Jan 13, 2025
jchate6
approved these changes
Jan 14, 2025
| from banzai.dbs import get_session, add_or_update_record | ||
| from banzai.dbs import Base, add_or_update_record | ||
| from sqlalchemy import Column, Integer, String, Float, create_engine, ForeignKey, DateTime, desc | ||
| from banzai.dbs import get_session |
There was a problem hiding this comment.
Not a big deal, but this could move to line 1 as well...
| @@ -59,6 +60,26 @@ def populate_photometric_standards(): | |||
| banzai_floyds.dbs.ingest_standards(args.db_address) | |||
|
|
|||
|
|
|||
| def add_order_location(): | |||
| parser = argparse.ArgumentParser(inspect.getdoc(banzai_floyds.dbs.add_order_location)) | |||
| parser.add_argument('--db-address', dest='db_address', | |||
There was a problem hiding this comment.
Should we check for this in the environment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.