-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Auth2 token generation and new fetching with tokens for the orgchart #3
base: choreo
Are you sure you want to change the base?
Conversation
src/App.js
Outdated
|
||
async function getAccessToken() { | ||
const tokenEndpoint = window?.configs?.tokenEndpoint ? window.configs.tokenEndpoint : "/"; | ||
const clientId = window?.configs?.clientId ? window.configs.clientId : "id";; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant semi colons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed here
}, []); | ||
|
||
async function getAccessToken() { | ||
const tokenEndpoint = window?.configs?.tokenEndpoint ? window.configs.tokenEndpoint : "/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comments for readability. Explain what these configs are for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added. Update Comments
Purpose
Fix frontend to handle auth 2 requests before calling endpoints secured with auth2
Changes