-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Q4 report for besu #92
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: jflo <[email protected]>
Signed-off-by: jflo <[email protected]>
|
||
# Questions/Issues for the TOC | ||
|
||
Besu contributors have been asking to use a single [CLA](https://en.wikipedia.org/wiki/Contributor_License_Agreement) instead of the DCO requirement for every commit, which is a source of unnecessary friction. The new [LFDT Charter](https://www.lfdecentralizedtrust.org/about/charter) does not mention anything about requiring either, and as such the Besu team intends to relax the DCO requirement in favor of a single CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has there been any discussions with LF Legal about this requested change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes via discord, no answers yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a discussion at the January 16th TAC meeting on this topic. It is important to note that even with CLA, the Linux Foundation requires that the DCO sign-offs will still happen on the code. Typically, the only reason that projects choose CLAs if they need a higher level of copyright protections.
|
||
# Contributor Diversity | ||
|
||
Due to an increase in trivial or automatically generated PRs, we have had to refine our [policies around insignificant contributions](https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md#guidelines-for-non-code-and-other-trivial-contributions) likely intended to farm future rewards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I understand that trivial contributions do take time to address, this can sometimes be the first entry that a new contributor has to the project that will allow them to understand the overall process of contribution. Also, given the introduction of a stalebot, it is very likely that these small issues will never be resolved as they are too low on the priority list. Maybe it would be good to allow for a new contributor to fix the batch of these issues by marking them as good first issues and/or help wanted. I would ask that the Besu maintainers determine if they are closing off too many potential avenues for contribution from new contributors who may turn into long-time contributors and possibly maintainers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are PRs being submitted without a corresponding issue, so no existing known work is being handled, and any "good first issues" will remain available for sincere contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tkuhrt for bringing up the topic for discussion in the TAC meeting.
- The current sentence in the
CONTRIBUTING.md
uses a strong language that may sound unwelcoming to new contributors. Please consider and re-evaluate the sentence "keep in mind that we do not accept non-code contributions". - Has the project team explored an option to trigger CI process on demand for new contributors? This will bar the automated tools/spam tools from overloading the resources.
- Does the project team have insights into how many automated PRs are raised? This may be a concern across all the projects, more information will assist and set-up a general recommendation across LF Decentralized Trust.
- Has the project team considered moving the documents to its own repository? This may keep the CI systems free of non-code contributions from running the tests.
ty for proofing Co-authored-by: Tracy Kuhrt <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
No description provided.