Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: elude lifetimes where possible #244

Merged
merged 1 commit into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions honeycomb-core/src/cmap/components/collections.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ pub struct VertexCollection<'a, T: CoordsFloat> {
pub identifiers: Vec<VertexIdType>,
}

unsafe impl<'a, T: CoordsFloat> Send for VertexCollection<'a, T> {}
unsafe impl<'a, T: CoordsFloat> Sync for VertexCollection<'a, T> {}
unsafe impl<T: CoordsFloat> Send for VertexCollection<'_, T> {}
unsafe impl<T: CoordsFloat> Sync for VertexCollection<'_, T> {}

collection_constructor!(VertexCollection, VertexIdType);

Expand All @@ -76,8 +76,8 @@ pub struct EdgeCollection<'a, T: CoordsFloat> {
pub identifiers: Vec<EdgeIdType>,
}

unsafe impl<'a, T: CoordsFloat> Send for EdgeCollection<'a, T> {}
unsafe impl<'a, T: CoordsFloat> Sync for EdgeCollection<'a, T> {}
unsafe impl<T: CoordsFloat> Send for EdgeCollection<'_, T> {}
unsafe impl<T: CoordsFloat> Sync for EdgeCollection<'_, T> {}

collection_constructor!(EdgeCollection, EdgeIdType);

Expand All @@ -104,8 +104,8 @@ pub struct FaceCollection<'a, T: CoordsFloat> {
pub identifiers: Vec<FaceIdType>,
}

unsafe impl<'a, T: CoordsFloat> Send for FaceCollection<'a, T> {}
unsafe impl<'a, T: CoordsFloat> Sync for FaceCollection<'a, T> {}
unsafe impl<T: CoordsFloat> Send for FaceCollection<'_, T> {}
unsafe impl<T: CoordsFloat> Sync for FaceCollection<'_, T> {}

collection_constructor!(FaceCollection, FaceIdType);

Expand Down
2 changes: 1 addition & 1 deletion honeycomb-core/src/cmap/dim2/orbits.rs
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ impl<'a, T: CoordsFloat> Orbit2<'a, T> {
}
}

impl<'a, T: CoordsFloat> Iterator for Orbit2<'a, T> {
impl<T: CoordsFloat> Iterator for Orbit2<'_, T> {
type Item = DartIdType;

fn next(&mut self) -> Option<Self::Item> {
Expand Down
2 changes: 1 addition & 1 deletion honeycomb-render/src/gui.rs
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ pub struct TabViewer<'a> {
viewport_rect: &'a mut bevy_egui::egui::Rect,
}

impl<'a> egui_dock::TabViewer for TabViewer<'a> {
impl egui_dock::TabViewer for TabViewer<'_> {
type Tab = CustomTab;

fn title(&mut self, tab: &mut Self::Tab) -> WidgetText {
Expand Down
Loading