Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add internal routine for 3D grid generation #256

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Dec 13, 2024

Description

Scope: core

Type of change: feat

Content description: TODO

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 76.52%. Comparing base (2b7e7fc) to head (0472e4c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/builder/grid.rs 0.00% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   77.98%   76.52%   -1.46%     
==========================================
  Files          47       49       +2     
  Lines        6676     6855     +179     
==========================================
+ Hits         5206     5246      +40     
- Misses       1470     1609     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99
Copy link
Collaborator Author

imrn99 commented Jan 2, 2025

TODO:

  • add vertex insertion
  • add another drawing of the expected IDs?
  • wire the routines to the builder
  • tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants