Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kernels): implement skewness computing routines #287

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Feb 14, 2025

Description

Scope: kernels

Type of change: feat

Content description: add a module with 2 new function to the kernel crate

  • each function takes a map as an input and compute the skewness of its cell
    • the 2-map function, compute_cell_skewness_2d computes face skewness
    • the 3-map function, compute_cell_skewness_3d computes face or volume skewness depending on the value of a const argument N: u8. Volume computation is currently unimplemented as I could not find a reliable definition for unstructured meshes

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 48.18182% with 57 lines in your changes missing coverage. Please review.

Project coverage is 84.97%. Comparing base (578d9c2) to head (671445b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
honeycomb-kernels/src/skewness/mod.rs 44.66% 57 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   85.41%   84.97%   -0.44%     
==========================================
  Files          63       65       +2     
  Lines        9257     9367     +110     
==========================================
+ Hits         7907     7960      +53     
- Misses       1350     1407      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 marked this pull request as ready for review February 17, 2025 14:40
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have the same name to compute cell skewness depending on the dimension of the cell?

Also, what about the capability to compute this skewness only for one cell?

I wonder if this iterator way of doing things is such a great idea; for example, we might want to compute this only on a part of the CMap, which we could, as a user, filter in advance.

}
}

fn compute_face_skewness_3d<'a, 'b, T: CoordsFloat>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this use the compute_cells_skewness_2d?

Co-authored-by: Cédric Chevalier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants