-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kernels): implement skewness computing routines #287
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
- Coverage 85.41% 84.97% -0.44%
==========================================
Files 63 65 +2
Lines 9257 9367 +110
==========================================
+ Hits 7907 7960 +53
- Misses 1350 1407 +57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have the same name to compute cell skewness depending on the dimension of the cell?
Also, what about the capability to compute this skewness only for one cell?
I wonder if this iterator way of doing things is such a great idea; for example, we might want to compute this only on a part of the CMap
, which we could, as a user, filter in advance.
} | ||
} | ||
|
||
fn compute_face_skewness_3d<'a, 'b, T: CoordsFloat>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this use the compute_cells_skewness_2d
?
Co-authored-by: Cédric Chevalier <[email protected]>
Description
Scope: kernels
Type of change: feat
Content description: add a module with 2 new function to the kernel crate
compute_cell_skewness_2d
computes face skewnesscompute_cell_skewness_3d
computes face or volume skewness depending on the value of a const argumentN: u8
. Volume computation is currently unimplemented as I could not find a reliable definition for unstructured meshes