Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TopoDS_Wire creation at import (IGES, STEP, CATIA, BREP). #84

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Remove TopoDS_Wire creation at import (IGES, STEP, CATIA, BREP). #84

merged 1 commit into from
Feb 4, 2025

Conversation

lelandaisb
Copy link
Contributor

No description provided.

CharlesPignerol
CharlesPignerol approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@CharlesPignerol CharlesPignerol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest completely removing this dialog box (QtImportOptionsDialog) from the sources and therefore no longer calling on it in QtMgx3DMainWindow::importCallback

@lelandaisb lelandaisb marked this pull request as draft February 4, 2025 09:57
@lelandaisb lelandaisb marked this pull request as ready for review February 4, 2025 10:13
@CharlesPignerol CharlesPignerol merged commit 53fa1c1 into main Feb 4, 2025
2 checks passed
@lelandaisb lelandaisb deleted the remove-import-wire branch February 5, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesPignerol CharlesPignerol CharlesPignerol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lelandaisb @CharlesPignerol